Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Rename security.knative.dev -> policy.run.google.cloud.com #732

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Rename security.knative.dev -> policy.run.google.cloud.com #732

merged 1 commit into from
Mar 30, 2020

Conversation

yolocs
Copy link
Member

@yolocs yolocs commented Mar 30, 2020 •
edited
Loading

Fixes #726

Proposed Changes

  • API group name and where it's used
  • Go package name
  • Installation namespace and labels
  • (Piggybacking) Allow controller service account to update k8s Event

Release Note

Rename security.knative.dev -> policy.run.google.cloud.com

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Mar 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yolocs
Copy link
Member Author

yolocs commented Mar 30, 2020

FYI @Harwayne

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/policy/v1alpha1/common_defaults.go Do not exist 100.0%
pkg/apis/policy/v1alpha1/common_lifecycle.go Do not exist 81.2%
pkg/apis/policy/v1alpha1/common_types.go Do not exist 88.9%
pkg/apis/policy/v1alpha1/common_validation.go Do not exist 95.7%
pkg/apis/policy/v1alpha1/eventpolicy_defaults.go Do not exist 100.0%
pkg/apis/policy/v1alpha1/eventpolicy_types.go Do not exist 50.0%
pkg/apis/policy/v1alpha1/eventpolicy_validation.go Do not exist 100.0%
pkg/apis/policy/v1alpha1/eventpolicybinding_defaults.go Do not exist 100.0%
pkg/apis/policy/v1alpha1/eventpolicybinding_types.go Do not exist 75.0%
pkg/apis/policy/v1alpha1/eventpolicybinding_validation.go Do not exist 91.7%
pkg/apis/policy/v1alpha1/httppolicy_defaults.go Do not exist 100.0%
pkg/apis/policy/v1alpha1/httppolicy_types.go Do not exist 50.0%
pkg/apis/policy/v1alpha1/httppolicy_validation.go Do not exist 100.0%
pkg/apis/policy/v1alpha1/httppolicybinding_defaults.go Do not exist 100.0%
pkg/apis/policy/v1alpha1/httppolicybinding_types.go Do not exist 75.0%
pkg/apis/policy/v1alpha1/httppolicybinding_validation.go Do not exist 91.7%
pkg/apis/policy/v1alpha1/register.go Do not exist 100.0%
pkg/reconciler/policy/istio/eventpolicybinding/controller.go Do not exist 100.0%
pkg/reconciler/policy/istio/eventpolicybinding/eventpolicybinding.go Do not exist 90.7%
pkg/reconciler/policy/istio/eventpolicybinding/resources/httppolicy.go Do not exist 100.0%
pkg/reconciler/policy/istio/eventpolicybinding/resources/httppolicybinding.go Do not exist 100.0%
pkg/reconciler/policy/istio/httppolicybinding/controller.go Do not exist 100.0%
pkg/reconciler/policy/istio/httppolicybinding/httppolicybinding.go Do not exist 84.6%
pkg/reconciler/policy/istio/httppolicybinding/resources/authorization_policy.go Do not exist 100.0%
pkg/reconciler/policy/istio/httppolicybinding/resources/request_authentication.go Do not exist 100.0%
pkg/reconciler/policy/subject_resolver.go Do not exist 89.7%

@Harwayne
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot merged commit 0a32e42 into google:master Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Harwayne Harwayne Harwayne left review comments

@capri-xiyue capri-xiyue Awaiting requested review from capri-xiyue

@ian-mi ian-mi Awaiting requested review from ian-mi

Assignees

@Harwayne Harwayne

Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update API group name and related naming
5 participants
@yolocs @knative-prow-robot @knative-metrics-robot @Harwayne @googlebot